fix: add missing PermissionDeniedError to litellm exceptions list#4832
Open
paipeline wants to merge 1 commit intoAider-AI:mainfrom
Open
fix: add missing PermissionDeniedError to litellm exceptions list#4832paipeline wants to merge 1 commit intoAider-AI:mainfrom
paipeline wants to merge 1 commit intoAider-AI:mainfrom
Conversation
Fixes Aider-AI#4829 litellm added PermissionDeniedError which was not in aider's EXCEPTIONS list, causing a ValueError crash during LiteLLMExceptions initialization: ValueError: PermissionDeniedError is in litellm but not in aider's exceptions list This is the same class of bug reported in Aider-AI#4829 (where BadGatewayError was missing in an older version). The root cause is that aider's exception list must be kept in sync with litellm's exception classes. Added PermissionDeniedError as non-retryable with a descriptive message, and added a corresponding test.
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LiteLLMExceptions.__init__()crashes with aValueErrorwhen litellm includes exception classes not present in aider'sEXCEPTIONSlist:This is the same class of bug reported in #4829. The
_load()method iteratesdir(litellm)and raisesValueErrorfor any*Errorclass that is aBaseExceptionsubclass but missing from aider's hardcoded list.Fix
PermissionDeniedErrorto theEXCEPTIONSlist as non-retryable (HTTP 403 — the user needs to fix their API key permissions, retrying won't help)Testing
All 7 tests in
tests/basic/test_exceptions.pypass, including the newtest_permission_denied_errortest.Fixes #4829